carbon icon indicating copy to clipboard operation
carbon copied to clipboard

Sketch Library: IBM Icons (16px, 20px) showing wrong icon asset for 'filter'

Open chrisconnors-ibm opened this issue 5 years ago • 7 comments

image

image

packages/icons/svg/16/filter.svg was moved to packages/icons/svg/16/settings--adjust.svg.

There is no packages/icons/svg/16/filter.svg anymore.

chrisconnors-ibm avatar Jan 09 '20 17:01 chrisconnors-ibm

related: https://github.com/carbon-design-system/carbon/issues/4130 https://github.com/carbon-design-system/carbon/issues/4849

chrisconnors-ibm avatar Jan 13 '20 16:01 chrisconnors-ibm

keepalive_bot this is still an issue: image

chrisconnors-ibm avatar Feb 14 '20 21:02 chrisconnors-ibm

Hey, is there any update as to where this falls on the roadmap/pipeline?

Its been plaguing us over in IoT where we've got a lot of filtering going on, and this issue is 2 months old without an assignee or estimated fix date, which makes me a little skittish 😄

lukefirth avatar Mar 02 '20 22:03 lukefirth

it was dependent on other under the hood work in elements which just shipped - maybe @joshblack can update.

chrisconnors-ibm avatar Mar 03 '20 01:03 chrisconnors-ibm

@chrisconnors-ibm one thing we should call out is that the library can be updated, it's just a manual process without the tooling in place.

Currently, I'm taking a look at our Sketch plugin again. Unfortunately, it seems like the rendering logic being used for the SVGs is rendering assets incorrectly. I will try and see how to resolve but in the meantime we can always hand update the design kit if there is anything pressing.

joshblack avatar Mar 04 '20 22:03 joshblack

fixed 🎉! will be in next update of the sketch icon libraries

laurenmrice avatar Mar 27 '20 13:03 laurenmrice

reopening because no one has updated the libraries, this is still asked about frequently https://ibm-watsonhealth.slack.com/archives/C0M053VPT/p1604613965233300

chrisconnors-ibm avatar Nov 05 '20 22:11 chrisconnors-ibm

hey @chrisconnors-ibm, we updated this in our Sketch kits. Let me know if it's still a thing.

sstrubberg avatar Nov 14 '22 16:11 sstrubberg

hey @chrisconnors-ibm, we updated this in our Sketch kits. Let me know if it's still a thing.

@sstrubberg I don't even have a Sketch License anymore to check! 🤣

chrisconnors-ibm avatar Nov 14 '22 18:11 chrisconnors-ibm