Jon Koops

Results 690 comments of Jon Koops

For this issue what we want is a very small piece of documentation on the [download page](https://leafletjs.com/download.html). Perhaps we should change the terminology on this page to something else as...

That seems like a good solution to me @Falke-Design

Perhaps we can do: ```css :focus { outline: 0; } :focus-visible { outline: initial; } ```

> Looks good to me! I couldn't get this working without converting the package to ESM first so I'm surprised that this is working. We're using the regular package [in...

Tests [are failing](https://github.com/modernweb-dev/web/actions/runs/7769718134/job/21312343273?pr=2635), looks like the path to `chai` is re-written to `node_modules/chai/index.js`, but this is not correct. The [`main` entry](https://github.com/chaijs/chai/blob/640d93221f1781a8e2fe3f25a892f01bdbeb86ba/package.json#L29) of `chai` is supposed to resolve to `node_modules/chai/chai.js`. Looks...

This issue is now also occurring in regular [test runs on our CI](https://github.com/Leaflet/Leaflet/actions/runs/7783864920/job/21223262461?pr=9242).

Aside from the crash itself, I think the main problem here is the lack of logging. It's not really possible to understand where this crash was coming from at a...

We've already tried lowering the concurrency to no avail. We have been able to [narrow down](https://github.com/Leaflet/Leaflet/pull/9242#issuecomment-1939175594) the problem to the fact that Web Test Runner requires `navigator.userAgent` and `navigator.serviceWorker` to...

+1 on this feature, we ran into some weird edge cases using `--node-resolve`. I think that Web Test Runner should opt purely into generating an import map, and use as...