Jon Koops

Results 690 comments of Jon Koops

@ahus1 since you are the new lead on the store team, can I ask you to take a look and see if this should get a different impact? Perhaps this...

You are correct @dcousens, that is in fact what [we did for Keycloak](https://github.com/keycloak/keycloak/pull/26265/files#diff-eeb93448269ec6cd4a3c7c3b55fd5a77ab95ca0a63ec3d46c13a25b739d29a42R1760-R1763).

Yeah, this is also an opportunity to align the implementations between Node.js and the browser, might be a good code-cleanup. Did some quick testing, but I was unable to get...

> In other words, the node.js `atob` function runs with `O(n^2)` time complexity! How code this irresponsible made it into the node.js codebase is beyond me. Oh damn, nice find!...

So perhaps take the `Buffer.from()` approach for Node.js and see if the perf for `atob` in browsers is acceptable? Would prevent the need to roll a bunch of custom code.

I have to agree with @dcousens that it's not really an issue that some of these functions are slow in Node.js, it is very clear that compatibility and performance with...

> Our latest thinking was that we'd drop default exports altogether. Named only. Perhaps this should be deprecated starting React 19?

Realistically, in what scenario would you deploy an application without HTTPS?

1. In this case `localhost` is considered a secure domain, so the Crypto API will work. If someone is testing with a custom domain locally they could use a self-signed...