Jon Koops comments

Results 690 comments of


                                            Jon Koops

Use JavaScript `constructor()` instead of custom `initialize()`

I have tried several methods of doing this in a backwards compatible way, but I believe we cannot keep things fully compatible. The reason for this is that the only...

Use JavaScript `constructor()` instead of custom `initialize()`

The real benefit here is that we align with what is expected of how classes behave in standard JavaScript. Any new users coming to Leaflet might already be familiar with...

Use JavaScript `constructor()` instead of custom `initialize()`

Draft PR up for discussion under #9906

Use JavaScript `constructor()` instead of custom `initialize()`

Yes, I am also concerned about plugins, how would they go about customizing built-in classes? The initialization hook mechanism is mostly used to extend the `Map` through `addHandler()`, but we...

Use JavaScript `constructor()` instead of custom `initialize()`

@almamigratoria-netizen I wish it were so easy. Unfortunately, the restrictions put on us by modern JavaScript classes likely prevent us from doing so.

Global L is exported via ESM

Looking into this, will keep you posted.

Global L is exported via ESM

There will almost certainly be a lot of projects out there using the UMD version of Leaflet, expecting it to keep working with the global `L`. However, the ESM version...

Global L is exported via ESM

Alternatively, we remove the global entirely, and make it part of the compatibility layer. Perhaps we can even move the UMD there. Or am I being crazy here?

I am talking about the [Leaflet v1 polyfill](https://github.com/Falke-Design/Leaflet-V1-polyfill), we could consider putting UMD there. But I am being too ambitious, realistically a lot of folks still rely on this. I...

Global L is exported via ESM

I am thinking, though, does it still make sense to provide the UMD version at all? We could simply keep maintaining it in v1.x. We'll be maintaining it for the...