Jon Koops comments

Results 690 comments of


                                            Jon Koops

Using 'seperate' declaration with CommonJS creates invalid types

Another issue somewhat related to this, is that the type definitions that are emitted for CommonJS are not really correct. For example, given the aforementioned input the following type is...

Using 'seperate' declaration with CommonJS creates invalid types

Yeah, I think the only way to do so would be to convert the source code to CommonJS as well. There really is no way for the TypeScript compiler to...

Bump typescript from 4.8.4 to 4.9.4

@dependabot rebase

When no classes are selected, classNames should return null

This is a great idea, however considering this changes the public API, this must be considered a breaking change.

When no classes are selected, classNames should return null

I am adding this to the milestone for a potential version 3.0, which will allow us to introduce some breaking changes.

When no classes are selected, classNames should return null

@dcousens @JedWatson could I get your take on this enhancement? I think it might be a valuable addition, especially for React users, but the pain of having a return value...

When no classes are selected, classNames should return null

> The fix for users should be as simple as `?? ''`, but, that's the argument against. Yeah, exactly, this could be an annoying fix to apply. I think we...

Preparing for version 3.0

@dcousens @JedWatson WDYT? Is this strategy something you can get behind as well?

Preparing for version 3.0

@agrant-1 Please refrain from sending e-mails to this GitHub thread, it will not unsubscribe you. Do so by selecting 'Unwatch' on the main page of the repository.

Perfect, I've created a [`v2.0`](https://github.com/JedWatson/classnames/tree/v2) branch for now (we can always delete it), so that if we make changes in the docs we can link there for users that might...