Jonah Williams
Jonah Williams
There is a lot of behavior in https://github.com/flutter/engine/blob/c617fd74c9f2f6ac16aa89bbeaffa392b376c8eb/shell/platform/android/io/flutter/plugin/platform/PlatformPlugin.java#L375-L466 that I don't see documented on the flutter side. We should probably clarify this a bit, because the combinations support here are...
This sounds good to me. I think we generally want to encourage folks to develop against stable anyway, so at this point the restriction may be do doing more harm...
Whether or not a file is formatted is something that dartfmt knows, but its not the tools responsibility to test. If we've tested that dartfmt has been invoked that is...
IIRC @cyanglaz had looked at something like this in that particular app a few months back, but we weren't able to repro it. I can definitely repro it easily though....
scrolling in the example app near ToT with --enable impeller reproduces it for me, though it is much more obvious in debug/profile mode than in release mode
correct, this is not about the frame freeze/lag
Looks like this was impeller only, probably my change to uniforms in https://github.com/flutter/engine/pull/35201 . Let me investigate and see if there is something obviously in the generated shaders
Generated shaders are https://gist.github.com/jonahwilliams/e2dbc01595eaa2ffecd03a787de9da5d , no obvious differences to me. Going to check the other commits too
If I'm understanding Option 2 in the context of a slimmed down Flutter, that would mean something like entirely removing HttpClient/HttpServer along with the associated native bits? That has a...
That sounds like option 1 though, the interfaces stay but the implementation changes