Jonah Williams

Results 585 comments of Jonah Williams

Now it occassionally freezes on the "backpressure" step or flashes black: https://github.com/flutter/engine/assets/8975114/5a583144-74f8-44c1-9d8f-672b9bf34aa4

Also if I rotate I get: E/flutter (29648): [ERROR:flutter/impeller/base/validation.cc(57)] Break on 'ImpellerValidationBreak' to inspect point of failure: New surface size is not allocatable.

Not crashing anymore! That said, we need to have at least recyclying of the underlying AHBs implemented, otherwise re-allocation of these starts to dominate the per frame costs: ![image](https://github.com/flutter/engine/assets/8975114/463c2b51-205e-42b2-9d7e-3dd64e2ded25)

I would also start thinking about how we test this - what it means to test it. We have some capability to unit test android code on CI too.

I think I'd just let it regress from now, ask folks to try it out and see. Possibly the apps are getting treated as "backgrounded" by the OS and so...

Looks like we need to do some plumbing for frame capture still.

I'm not sure if this is actually flaky or not. all I can see in the logs is that the test script failed to attach to the device. We've been...

et is reading a JSON file that describes the build. We can just add the impeller_unittests target into that file?

This is something I looked at fairly extensively when we refreshed the material widget catalog to meet android accessibility guidelines. Specifically, Android recommends at least 48 by 48 minimum hit-testable...

Oh, and the other issue with increasing hit test area: it's not possible to guarantee that these hit test regions do not overlap, unless we did another layout pass