Jonah Williams comments

Results 585 comments of


                                            Jonah Williams

Fix logical error in TimePickerDialog - the RenderObject forgets to update fields

Ahh my bad, I should have asked for a test for this one

Startup `flutter` faster (cache git calls)

For the actual caching behavior you've outlined, I would defer to our resident git authority @christopherfujino . I would say that in general I'm okay with trying this out because...

Cannot load package assets from a directory

``` Error: unable to find directory entry in pubspec.yaml: /Users/kenzieschmoll/develop/devtools/packages/devtools_app/packages/perfetto_compiled/ ``` This seems like a bogus message that we should fix. IIRC the intention of packages/ is to pull assets...

[3.3] Rendering issues

I asked to be assig

[3.3] Rendering issues

Oops. I asked to be assigned last week, but that was Friday afternoon so I haven't investigated yet

[3.3] Rendering issues

We believe that this is related to the CP we have scheduled in https://github.com/flutter/flutter/issues/112603, however we have been unable to reproduce this particular issue. If you are experiencing this and...

[Impeller] give geometry classes similar API as entity / implement strokepathgeom

Converting to a draft for now, I pushed up what the changes would look like with (most of) SolidStrokeGeometry implemented

[Impeller] give geometry classes similar API as entity / implement strokepathgeom

I've verified everything is working correctly on those tests and updated to ToT. Going to land this now so we can close out this refactor. If anyone notices a problem...

[Impeller] cache glyph atlas if contents are unchanged

FYI @dnfield

[Impeller] cache glyph atlas if contents are unchanged

I ran some benchmarks on the flutter gallery using a newer iPhone. This is a tiny biy (0.5 -1 ms) faster, but we already know that isn't a particularly text...