John Stilley

Results 111 issues of John Stilley

## What is the change? Here I rename `Database3` to `Database` everywhere in ARMI. However, I preserve the old `Database3` end point, as a temporary measure, so this PR is...

cleanup

@albeanth and I identified ~two places~ one place where the ARMI codebase does not support the new `EOL` time point being written to the database (added in [PR 1090](https://github.com/terrapower/armi/pull/1090)): 1....

bug

The `armi/tests/` directory has a bunch of test reactors in ARMI format, but the files are all jumbled together. It would be easier for ARMI users and developers if all...

cleanup
testing

## What is the change? It appears there was a bug where Components inside a Block (like fuel pins) would have the wrong location if they were on a Hex...

bug

## What is the change? 1. Fixed a bug in `plotBlockDiagram()`. 2. To help, I added the method `HexBlock.cornersUp()`, as I imagine it will be a helpful utility to have....

bug

The tools we use to validate settings come from th `Query` class, which is in [settingsValidation.py](https://github.com/terrapower/armi/blob/abd1db4adfa0c536f9bf9f08f0f1e8b74b1cd0d7/armi/operators/settingsValidation.py). But that file is at: `armi/operators/settingsValidation.py`, for some reason. Surely that should be under...

architecture
cleanup

ARMI has two Jupyter Notebook tutorials, used in the docs, that are also run through as unit tests to make sure they still work: https://github.com/terrapower/armi/blob/abd1db4adfa0c536f9bf9f08f0f1e8b74b1cd0d7/armi/tests/test_notebooks.py#L33 ARMI is a framework, and...

architecture
cleanup
testing
ci

Right now, ARMI forcibly adds a Spent Fuel Pool (SFP) to every `Reactor` object: https://github.com/terrapower/armi/blob/5a41b25fe9f262acb03347923443c4a2808837db/armi/reactor/reactors.py#L213-L214 I think this is rather a lazy idea and default, meant to temporarily help out...

architecture

In the [Table Size](https://sphinx-simplepdf.readthedocs.io/en/latest/css.html#table-size) section of the docs, there is a link to a "Demo PDF" that is missing: ![Image](https://github.com/user-attachments/assets/9ee970d6-c176-474e-9aea-1d0fe394101f) The "Demo PDF" is supposed to be at this address:...

## What is the change? Why is it being made? Here I remove the method `Composite.getNumberDensities()` at the request of the user base. It leads to too many complicated concerns...

enhancement