armi icon indicating copy to clipboard operation
armi copied to clipboard

Removing Composite.setNumberDensities()

Open john-science opened this issue 8 months ago • 1 comments

What is the change? Why is it being made?

Here I remove the method Composite.getNumberDensities() at the request of the user base. It leads to too many complicated concerns about number densities in, say, a Block which contains multiple Components with differing number densities. So now the method getNumberDensities() only exists on Components, which by definition have no children.

close #1374

SCR Information

Change Type: features

One-Sentence Description: Removing Composite.getNumberDensities to simplify concerns about auto-homogenizing materials.

One-line Impact on Requirements: NA


Checklist

  • [x] This PR has only one purpose or idea.
  • [x] Tests have been added/updated to verify any new/changed code.
  • [x] The documentation is still up-to-date in the doc folder.
  • [x] The code style follows good practices.
  • [x] The dependencies are still up-to-date in pyproject.toml.

john-science avatar Apr 17 '25 22:04 john-science

@jakehader @drewj-tp Bump.

john-science avatar Apr 23 '25 17:04 john-science

This pull request has been automatically marked as stale because it has not had any activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 13 '25 03:09 github-actions[bot]