Why is settingsValidation under operators?

Open john-science opened this issue 1 year ago • 4 comments

The tools we use to validate settings come from th Query class, which is in settingsValidation.py.

But that file is at: armi/operators/settingsValidation.py, for some reason.

Surely that should be under armi/settings/, right?

Sep 15 '24 04:09 john-science

Ouch. I just checked, and this API-breaking import is used widely downstream.

So, to provide a more stable API, this change will have to first involve a DeprecationWarning, and then a very long intermediate period before the change is made final.

Sep 17 '24 23:09 john-science

Seems duplicate of #1464 , no?

Sep 24 '24 17:09 keckler

Seems duplicate of #1464 , no?

You're right! Thanks!

Sep 25 '24 02:09 john-science

I should note that this ticket is Allllllmost done.

We actually have already moved the code, what is left under /operators/ is just a stub pointing to the new location for backwards compatibility.

https://github.com/terrapower/armi/blob/1b0d536d71ea0f90091b5d1bbade1862f80f78ea/armi/operators/settingsValidation.py#L14

May 13 '25 22:05 john-science