John Stilley
John Stilley
## What is the change? Removing references to versions of the database prior to `Database3`: * `armi.bookkeeping.db.convertDatabase()` * `armi.cli.database.ConvertDB` ## Why is the change being made? This version of the...
ARMI has [some migration scripts](https://github.com/terrapower/armi/tree/64351a0a5538e6a150d2c4f9a1183fa6558f5269/armi/migration) from the dawn of time. But after a couple of years of trying, I can't find any examples of these old databases to test and...
## What is the change? Three bugs were found, and fixed: * [The hex grid/ascii map was rotated 60 degrees from the blueprints](https://github.com/terrapower/armi/pull/1649/commits/4261b82221d438cd47a8898d4d28ac7ad9ef3601) * [HexGrid._makeOffsets()](https://github.com/terrapower/armi/commit/467a613505a081d31da3f73548dcaca5e2d94f6a) didn't reset the offsets before...
## What is the change? Using `ruff` to enforce a maximum line length of 120. Because `ruff` is doing the enforcing, GitHub CI will catch and enforce this new rule...
In the ARMI docs, there is a full [list of Nuclides](https://terrapower.github.io/armi/.apidocs/armi.nucDirectory.nuclideBases.html#id1) table. When rendered to PDF it is about 109 pages long. I think there are two possibilities: 1. This...
In our docstrings, we make use of two different ways to write "Warnings" and "Notes". The first uses RST syntax: https://github.com/terrapower/armi/blob/5879f956d6e57164ac84e7fd571be04a8a43fc29/armi/reactor/assemblies.py#L345-L346 And the second is to use the NumPy docstring...
This (wildly used) `Core` property `powerMultiplier` is poorly named: https://github.com/terrapower/armi/blob/e2dba79a4e68c23a0dd06b90ea2e4cbaca335095/armi/reactor/reactors.py#L374-L384 I think this should be renamed `symmetryFactor`. This will break the API and will require changes in several downstream repos....
Our current function to create a reactor for unit tests is widely used in ARMI and the ARMI ecosystem: https://github.com/terrapower/armi/blob/main/armi/reactor/tests/test_reactors.py#L139-L143 However, it loads a full reactor and is this rather...
It appears to me we should be able to remove the method `FuelHandler.prepSearch()`: https://github.com/terrapower/armi/blob/0977ee48953e2099d434c6df32a1b184c7ae259f/armi/physics/fuelCycle/fuelHandlers.py#L207 Because it hasn't done anything but raise a `DeprecationWarning` in years: https://github.com/terrapower/armi/blob/0977ee48953e2099d434c6df32a1b184c7ae259f/armi/physics/fuelCycle/fuelHandlers.py#L226-L230 I can find no...