John Stilley

Results 111 issues of John Stilley

## What is the change? Why is it being made? This was a new feature request. In the past, all orientations for high-level BP / Core children start with the...

feature request

## What is the change? Why is it being made? Adding some tooling and automation so that people can more easily build the docs locally. You will notice in this...

documentation

This is extremely unclear: https://github.com/terrapower/armi/blob/ac9a81c70ecc8b48dd790643b3e9a98b67c098a4/armi/interfaces.py#L291-L292 The word `function` already has a very specific meaning in Python, and this is not it at all. This should be renamed to "utility" or...

enhancement
low priority

We have a class called `LocationBase`: https://github.com/terrapower/armi/blob/6febc6529f4f8430fe56aa67d4f68ae805469324/armi/reactor/grids/locations.py#L30 But in the class docstring it says that this was only needed because of a bug in Python 2: https://github.com/terrapower/armi/blob/6febc6529f4f8430fe56aa67d4f68ae805469324/armi/reactor/grids/locations.py#L38-L41 Since ARMI now...

good first issue
cleanup

## What is the change? Why is it being made? I have asked my power users and we believe the following `Setting`s are unused and can safely be deleted: *...

cleanup

@keckler noted that ARMI developers too frequently have to make PRs into ARMI to deal with `Setting`s and `Parameter`s defined in ARMI. That is a system design problem. It seems...

cleanup

## What is the change? Why is it being made? The documentation currently contains a "Settings Report". This PR is a very small change to that report; right at the...

documentation

## What is the change? Why is it being made? We want to set `armi.material.materials.FAIL_ON_RANGE` to `True` by default. For the past ~14 years, there has been an uncomfortable situation...

feature request

The thermal expansion logic in ARMI seems to hyper-specific to Sodium Fast reactor designs. That is counter to the ARMI design goals of being a tool useful to the general...

architecture
complex

## What is the change? Why is it being made? Our user docs looked like this: But that is confusing because all of these "parameters" pages are parameter reports (list...

documentation
cleanup