José Luis Millán comments

Results 264 comments of


                                            José Luis Millán

Possible extension: SIP SUBSCRIBE/NOTIFY dialog

Thanks @ikq! Let us some days to check it. I'll review it after the weekend.

New UA config param for global extra headers

> Merge? Once I prepare a new version in the docs I'll merge and add this config.

fix: sctp mem violation

Closed in favour of #943

consumer NACK with the specified sequence number packet but the retransmission fails

Thanks for the detailed observations. Next week some of us won't be fully online, but we'll check at this as soon as possible.

An overflow and crash risk in RTC::Transport::SendRtcp

Good finding @billzmh, There's an ongoing fix for this. Thanks for the report.

ObjectPoolAllocator

NOTE: Currently measuring the CPU time differences with pools VS new/delete.

ObjectPoolAllocator

Converted to draft while re-testing re-profiling. Feel fee to try it out and review.

ActiveSpeakerObserver: "dominantspeaker" listener does not work properly if I immediately add a fresh Producer.

`const producer = transport.produce(...);` Why aren't you awaiting for `transport.produce()`? It returns a Promise, not a Producer. `const producer = await transport.produce(...);`

`_this2._request_sender.send()` causes error in `Dialog/RequestSender`

Can you please provide with the corresponding JsSIP logs?

`_this2._request_sender.send()` causes error in `Dialog/RequestSender`

Closing due to lack of information.