JsSIP icon indicating copy to clipboard operation
JsSIP copied to clipboard

`_this2._request_sender.send()` causes error in `Dialog/RequestSender`

Open alexsharabaykoidt opened this issue 4 years ago • 4 comments

Dialog/RequestSender calls _this2._request_sender.send() in 491 status handler to make another request attempt.

But _request_sender doesn't exist so this line causes exception.

Looks like this.send() is good alternative for this line

alexsharabaykoidt avatar Apr 22 '21 15:04 alexsharabaykoidt

Can you please provide with the corresponding JsSIP logs?

jmillan avatar Apr 23 '21 05:04 jmillan

Closing due to lack of information.

jmillan avatar May 17 '22 11:05 jmillan

@jmillan why do you need logs? If you simply look at the code you will easily notice that it's a bug/typo. this._request_sender is undefined.

This produces a crash, usually when holding/un-holding multiple times repeatedly.

rcidt avatar Oct 14 '22 15:10 rcidt

Let's reopen.

ibc avatar Oct 15 '22 08:10 ibc

PR https://github.com/versatica/JsSIP/pull/787

ibc avatar Oct 28 '22 12:10 ibc

Thanks for the report @alexsharabaykoidt and @rcidt

jmillan avatar Nov 05 '22 15:11 jmillan