Results 264 comments of José Luis Millán

> What do we do with 'getSender'? This is needed for mute? I commented here: https://github.com/Haardt/JsSIP/pull/1/files#r586408690 > I think I can publish both projects at the end of next week....

please @GEverding, run `gulp format`

@phwb, Any chance you could comment on this one?

Wow, your pointing a 13 year old forum content. Can you try this patch: ```diff diff --git a/lib/RTCSession.js b/lib/RTCSession.js index 7003c25..dcb41c3 100644 --- a/lib/RTCSession.js +++ b/lib/RTCSession.js @@ -962,7 +962,11 @@...

> but apparently there's still something wrong: You don't specify whether you were trying to send the DTMF after receiving 100 or 1XX. I'm certain it won't work before 1XX,...

Can you please add the corresponding test in `test/test-parser.js`?

BTW, thanks for the PR @markusatm and sorry for the delay. Once with the test we'll be able to merge it.

You can create a PR and add the type in https://github.com/versatica/JsSIP/blob/master/lib/UA.d.ts file

Hi, Which RFC does it implement and to which extent? What is it missing from the spec, if any? NOTE: In order for this to be considered for a PR...

@ikq, Due to the generic nature of the specification, I think this could become part of JsSIP. At the same level as RTCSession. There are two clear implementation parts: `Subscriber`...