Results 264 comments of José Luis Millán

Hi @alebcay, I find the changes OK overall, but this PR modifies a file in sdptransform, which is an external dependency that cannot be modified here.

Ok. This PR already targets libdsptransform 🤦 , sorry for the confusion @alebcay. We were thinking it was targeting libmediasoupclient. I just have one question: ```diff - install(TARGETS sdptransform DESTINATION...

I can't think of any solution which does not imply surrounding the forward declarations with the (begin-category and end-category) directives, which I can't afford. It's a pity, other than this...

Without any kind of description this PR will be closed.

The same way `Registrator` provides a `setExtraContactParams` method, it can be added a new `setExtraContactUriParams`. Whenever it comes to generate the `Contact` header field within `Registrator`, you have to parse...

Or `setExtraContactUriParams` could generate `this._contact` itself.

Summarizing: ```js setExtraContactUriParams(params) { const contact = JsSIP.Grammar.parse(this._contact, 'Contact')[0].parsed; contact.uri.clearParams(); for (const { key, value } of params) { contact.uri.setParam(key, value); } this._contact = contact.toString(); } ```

The last NOTIFY arrived to 1st phone should simply not reach the dialog since it should not exist, in case this was terminated. Please attach here the full JsSIP logs...

Ok, then provide us the full JsSIP logs for the 2nd phone.

Only logs are needed, not any .js file. The issue is that JsSIP is trying to send a NOTIFY upon failure event. By that moment the `RTCSession` is already closed....