José Luis Millán
José Luis Millán
H @ikq, `Dialog` should be agnostic to the method. Why can't current `Dialog` implementation be used here? It has basically the `sendRequest()` method that you can call, and it will...
There is INVITE related code in Dialog because a dialog for INVITE method needs to behave in certain way, different to generic dialogs, but that's an implementation detail. Other clases...
Hi @ikq, We are super busy lately. Please keep using your branch and update this PR whenever you find any issue/enhancement. Also, tests would accelerate the adoption.
@ikq, more than an external test I mean tests in JsSIP as part of this PR, testing the clases created here.
Hi, Yes, in order for this PR to be merged we need tests in JsSIP project. You don't need two JsSIP instances, just one instance and you should inject a...
Thanks a lot @ikq, I'm quite busy at the moment but I'll take a look when I can.
Hi @ikq, I don't see the reason for 'dialogCreated' event in Subscriber. Is there for historical/testing purposes?
As commented via phone lets create this new signature and also maintain the previous one: ```c++ SendTransport* Device::CreateSendTransport( SendTransport::Listener* listener, const std::string& id, const json& iceParameters, const json& iceCandidates, const...
It's up to date.
This PR considers any message starting with CRLF a keep alive. The original implementation is intentional, considering CRLF a keep-alive beacon. An option would we considering one or two CRLF...