JsSIP icon indicating copy to clipboard operation
JsSIP copied to clipboard

Improve matching of empty message received

Open BorisMorel opened this issue 4 years ago • 2 comments

Hi,

With PjSIP, empty messages received was not only "\r\n" (see below). So I change the strict matching by a regular.

Other question, why not response to this ?

Regards, Boris.

image

BorisMorel avatar Nov 17 '21 15:11 BorisMorel

This PR considers any message starting with CRLF a keep alive. The original implementation is intentional, considering CRLF a keep-alive beacon.

An option would we considering one or two CRLF as keep alive: /^(\r\n){1,2}$/

Being double CRLF defined here https://datatracker.ietf.org/doc/html/rfc5626#section-3.5.1

jmillan avatar Jan 17 '22 09:01 jmillan

Hello When do you plan to implement this fix?

UbiManu avatar Feb 09 '22 14:02 UbiManu

Closed in favour of #791

jmillan avatar Nov 05 '22 23:11 jmillan