plugins
plugins copied to clipboard
[video_player] Added setMaxVideoResolution to disambiguate over different video stream resolutions
Since HLS streams can deliver multiple tracks with a single URL, it could be particularly useful to set a maximum video resolution to spare network bandwidth instead of picking the best stream that could also be calculated according to the device network speed.
The main issue:
- https://github.com/flutter/flutter/issues/109414
Related issues:
- https://github.com/flutter/flutter/issues/84170
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [X] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [X] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use
dart format.) - [X] I signed the CLA.
- [X] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g.
[shared_preferences] - [X] I listed at least one issue that this PR fixes in the description above.
- [X] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [X] I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style. - [X] I updated/added relevant documentation (doc comments with
///). - [X] I added new tests to check the change I am making, or this PR is test-exempt.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Hey @stuartmorgan, I added tests on both sides: Android and iOS native! Let me know if it's ok
Hey @stuartmorgan , do we have an ETA for this PR?
I need to understand if this feature will ever land in production.
cc @hellohuanlin
@stuartmorgan Could you take a look at this to see if this API is reasonable?
@AngeloAvv Are you still planning on updating this based on the comments above?
@AngeloAvv Are you still planning on updating this based on the comments above?
@stuartmorgan @reidbaker sure! I just need to find a spot in the next weeks to address the changes.
We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages.
Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord.
Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state!