John Watson

Results 328 comments of John Watson

I'd be willing to look at a patch for this, but I don't think it's a terribly important bug, TBH. blocking the export thread seems like a bad idea, and...

I think we would probably _not_ want to make this a part of our official SDK API surface area. It's an internal utility class, and that's not really the business...

> maybe not in this form, but I could see an argument for declarative config supporting this in some way that doesn't require copy-pasting this code everywhere (https://github.com/open-telemetry/opentelemetry-configuration/blob/main/CONTRIBUTING.md#properties-which-pattern-matching) I could...

no longer blocked by the spec?

I don't think we can really change the system property at this point, so we should consider the message to be wrong. Can you contribute a small PR to fix...

It's been changed to a compile-time dependency only, so if you want to use the incubator module, you'll need to add it as an explicit dependency. Not a bug. Very...

Looks like we'll need to figure out another strategy for equals verification, since we have to continue supporting java < 17.

If this is specifically about how to customize a prometheus exporter with the agent, I think we should move this question/issue over to the instrumentation repository. Does that make sense...

> > Discussed in open-telemetry/opentelemetry-java-instrumentation#5163 > > @jkwatson ^^ does that mean we should close this issue then?

How would you imagine configuring this, in general? I'm not opposed to adding this feature to the ThrottlingLogger itself, but how would you then configure that in the SDK?