John Watson

Results 328 comments of John Watson

> > Seems easy enough to have your delegate keep track of the `shutdown` state, and just use that to make `forceFlush` a no-op after shutdown has been called. Am...

Why do you want to skip the controlled shutdown of the worker?

Making the BatchSpanProcessor extendable wouldn't solve your issue, then, since we will still need to shut down the worker thread, even if it doesn't flush its spans before doing so....

Yes! This would be great to have. I don't really care for the defaults, and would love to customize things so the default light settings (color, dropoff profile, animations, etc)...

I'm going to move this over to the instrumentation repository, since it involves the functioning of the spring-boot-starter and not the SDK or API themselves.

> @jkwatson it's not really about spring IIUC > > this is part of the dependency tree > > * SDK needs to have the same version of `opentelemetry-api-incubator` or...

I think this is fine as an optional env var, and in java, it's fine just being supported in the agent.

moving this to the instrumentation repository, since it's agent-specific

I sure would like a convenience method that (I think) takes a name and some attributes, and skips the builder. `logger.emit("paymentReceived", Attributes.of("amount", 3.14, "currency", "Dollars"))` Or however we spell Attributes...