John Watson
John Watson
It looks like dgs is based on graphql-java, which has library instrumentation (https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/graphql-java/graphql-java-20.0/library). I wonder if you just plug in that instrumentation library if a bunch of these issues would...
The "library" instrumentation doesn't require the javaagent. You can just plug it in programmatically. You might need to figure out how to hook it into dgs, but it doesn't need...
Given this documentation, I would guess it'll work just fine: https://netflix.github.io/dgs/advanced/instrumentation/
> @jkwatson That's exactly what I am doing in my code, [manually instrumenting](https://github.com/govi20/dgs-otel/blob/main/src/main/java/com/sample/dgs_otel/telemetry/TracingInstrumentation.java) using SimpleInstrumention implementation I recommend trying the library instrumentation then, and raising issues in the instrumentation repo...
The issue won't be with the core libraries. It's definitely an issue with making the instrumentation correctly propagate the context where it needs to go.
Is this still needed/wanted? It's been open a while, and I don't have a problem with it, but let's either get it merged, or close it.
> Let me know if you want me to submit a PR to fix this. please!
The only case we recommend using the GlobalOpenTelemetry instance is if you're using the OTel javaagent. In that case, the agent itself controls the lifecycle of the instance, so you...
Yes, it would be great to have proper hierarchical headers!
dupe of #287?