John Watson
John Watson
Does client code belong in this repo? I would hope the opamp project could publish a client that we could consume, rather than us having to become maintainers of it.
@LikeTheSalad Is the goal going to be to create a generic java OpAmp client, or a thing that is specifically for configuring the OTel Java SDK? If the latter, then...
> > @LikeTheSalad Is the goal going to be to create a generic java OpAmp client, or a thing that is specifically for configuring the OTel Java SDK? If the...
> @trask / @jkwatson any intent to spend additional time reviewing before I merge? I unfortunately won't have time. Make it so.
You can't make the api depend on the incubator; that introduces a circular dependency, since the incubator depends on the api.
@royteeuwen any update on getting an integration test working?
> > @royteeuwen any update on getting an integration test working? > > I got everything working in my separate repo but had to wait for bnd 7.1 to be...
@jack-berg do you still want this? Happy to get it merged, but needs a rebase/main merge & Jason's suggestion is a good one, I think.
Can you explain what your use-case is, and why you need to extend, rather than just create a wrapper that delegates some functionality to the underlying SpanProcessor?
Seems easy enough to have your delegate keep track of the `shutdown` state, and just use that to make `forceFlush` a no-op after shutdown has been called. Am I missing...