opentelemetry-java icon indicating copy to clipboard operation
opentelemetry-java copied to clipboard

Make IncludeExcludePredicate public

Open zeitlinger opened this issue 4 months ago • 4 comments

Is your feature request related to a problem? Please describe.

https://github.com/open-telemetry/opentelemetry-java-contrib/pull/2031 makes use of IncludeExcludePredicate

Describe the solution you'd like

make the class public

Part of https://github.com/open-telemetry/opentelemetry-java/issues/6970

zeitlinger avatar Aug 20 '25 06:08 zeitlinger

I think we would probably not want to make this a part of our official SDK API surface area. It's an internal utility class, and that's not really the business of the OpenTelemetry SDK to be publishing.

jkwatson avatar Aug 20 '25 17:08 jkwatson

maybe not in this form, but I could see an argument for declarative config supporting this in some way that doesn't require copy-pasting this code everywhere (https://github.com/open-telemetry/opentelemetry-configuration/blob/main/CONTRIBUTING.md#properties-which-pattern-matching)

trask avatar Aug 20 '25 18:08 trask

maybe not in this form, but I could see an argument for declarative config supporting this in some way that doesn't require copy-pasting this code everywhere (https://github.com/open-telemetry/opentelemetry-configuration/blob/main/CONTRIBUTING.md#properties-which-pattern-matching)

I could see that as a possibility, if @jack-berg is ok supporting it forever as a part of the declarative config APIs.

jkwatson avatar Aug 26 '25 01:08 jkwatson

We could even add a sentence to the spec:

SDKs SHOULD provide a method named ... to parse this

zeitlinger avatar Aug 26 '25 08:08 zeitlinger