Jon Haitz Legarreta Gorroño
Jon Haitz Legarreta Gorroño
Thanks for considering the comments @gregsharp :100:. > Sure. If the PR contains multiple commits, should I squash the work into a single commit and update the message at that...
The buffer allocation/de-allocation method introduced memory leaks :unamused:: https://open.cdash.org/viewDynamicAnalysis.php?buildid=7954824 I will push a WIP PR so that if @blowekamp or anyone that is able to run Valgrind on the branch...
> I will push a WIP PR so that if @blowekamp or anyone that is able to run Valgrind on the branch and has the bandwidth can confirm whether the...
A few notes: - I know the module gets less use than `GDCM`, but if it is in the toolkit, it should get some more testing. - I could not...
> Making the test quantitative would be good, but that can be a follow-up commit. This is good as-is. Sounds reasonable. Note that I have not been able to compile...
> and the only mention of DCMTK in additional include directories is C:\Dev\ITK-git\Modules\IO\DCMTK\include Meaning that including the directory is missing in the `CMakeLists.txt` file? I did try to add it...
This is still relevant stale bot. I am willing to take up this as soon as #2817 gets resolved.
This is still relevant stale bot.
> @jhlegarreta adding a few example tests where this could be applied would make it a "good first issue". I should have done this when I opened the issue, I...
Related to the issue is marking the end of tests: https://github.com/InsightSoftwareConsortium/ITK/pull/2196#discussion_r546761209.