ITK icon indicating copy to clipboard operation
ITK copied to clipboard

`MeshIO` classes Write methods fail/timeout and round-trip test fail

Open jhlegarreta opened this issue 2 years ago • 2 comments

Description

Some of the MeshIO (Modules/IO/Mesh*) classes Write* methods fail/timeout or the round-trip (write data, read back and compare the read values to the expected ones) fail.

Steps to Reproduce

The failing tests are located in the test module of each Modules/IO/Mesh* module. The failing calls have been commented out in the tests and a FIXME tag was put in the comments while adding the tests for these classes in #3403.

Expected behavior

Write methods work; tests do not timeout; round-trip checks pass.

Actual behavior

Some of the write methods do not work; tests timeout (MeshBYU); round-trip checks do not pass.

Reproducibility

%100.

Versions

master.

Environment

Issues were being reported in all platforms used by the CI builds. However, tests were passing on a Windows 7, MSVC 2019 machine.

Additional Information

Cross-referencing https://github.com/InsightSoftwareConsortium/ITK/pull/3403#issuecomment-1141132531

Slightly related to this is the need to improve the buffer allocation method/buffer deletion, as noted in the referenced comment.

jhlegarreta avatar Jun 01 '22 03:06 jhlegarreta

The buffer allocation/de-allocation method introduced memory leaks :unamused:: https://open.cdash.org/viewDynamicAnalysis.php?buildid=7954824

I will push a WIP PR so that if @blowekamp or anyone that is able to run Valgrind on the branch and has the bandwidth can confirm whether the fix removes the leaks from the target test.

jhlegarreta avatar Jun 04 '22 01:06 jhlegarreta

I will push a WIP PR so that if @blowekamp or anyone that is able to run Valgrind on the branch and has the bandwidth can confirm whether the fix removes the leaks from the target test.

PR #3459

jhlegarreta avatar Jun 04 '22 01:06 jhlegarreta