ITK icon indicating copy to clipboard operation
ITK copied to clipboard

Compiling `DCMTK` shows a Mac file format warning for `arith.h`

Open jhlegarreta opened this issue 2 years ago • 2 comments

Description

When compiling ITK with the IODCMTK third-party module, the compiler shows a warning saying that the file config/include/dcmtk/config/arith.h is generated with Mac file format, and that it should be converted to DOS/UNIX format.

Steps to Reproduce

Clone ITK at the specified commit (or master) and compile with Module_ITKIODCMTK set to ON.

Expected behavior

No warnings when compiling.

Actual behavior

config/include/dcmtk/config/arith.h is generated with Mac file format.

itk-Bin/Modules/ThirdParty/DCMTK/ITKDCMTK_ExtProject-build/config/include/dcmtk/config/arith.h(1,1):
warning C4335: Mac file format detected: please convert the source file to either DOS or UNIX format

Reproducibility

100%

Versions

ITK master at commit 69b7c4ef036ce36b32ace738db111d3d4720dbe4

Environment

OS: Windows 10 CMake: 3.20.3 Compiler: MSVC 2019 19.29.30133.0

Additional Information

Compiling the DCMTK library as a separate/system project at the pointed tip shows the same warnings.

I tried to find where in the upstream repository the arith.h file is generated. It looks like it is here: https://github.com/InsightSoftwareConsortium/DCMTK/blob/master/config/Makefile.in

But I did not find why a Mac format file is being generated.

I also see that the DCMTK version used by ITK is quite behind the upstream version.

jhlegarreta avatar Oct 10 '21 15:10 jhlegarreta

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 10:04 stale[bot]

This is still relevant stale bot.

jhlegarreta avatar Apr 16 '22 13:04 jhlegarreta