Justin Chadwell
Justin Chadwell
I think this is a somewhat known issue? `dagger init` uploads parent directories - up to the root, this *was* so it could detect parent `go.mod`s and similar. I'm sure...
@sipsma I think with the refactorings to the module loading system these issues should be resolved now right? We should only be uploading the files needed for the module.
@zoupingshi can you please rebase? There are conflicts on main, we've done a big refactor of module loading recently. Otherwise LGTM.
I think this aligns with some refactoring I previously considered - the issue is that the internals of `CacheExporterTarget` at the moment are almost entirely non-apparent from the caller (which...
cc @sipsma @vito I think this feels right to me? A bit messy, but can clean that up if this looks *about* right.
Oop, noticed that somewhere *some* change was adding `nil` llb dependencies - fixed that, think it was an oversight. Should be good now :tada: @sipsma the changes you've made look...
> I chose to prefix the enum values manually because there might be an overlap between different kinds of enums. Yup, allowing prefixing sounds good to me, we can do...
> What I meant here was actually not doing any kind of magic in the code generator, but encouraging users to prefix their enums themselves. That was they can account...
These aren't all going to make it into v0.14.0 - moving out of the milestone.
> While reviewing this I was thinking that I'd love if there's a way I could just make ALL exit codes not to fail I did think about this -...