Justin Chadwell
Justin Chadwell
Actually, wait, looks like the failure is still happening: https://v3.dagger.cloud/dagger/traces/248ea0aa7edf03b2ca2637acecea4408?listen=e14175260e66c6d6&listen=9fef1420054482af&listen=7be3ecd4d2a4d49e&listen=29c51b381c6db961#29c51b381c6db961:L287 ``` Error: input: defaults.filesNegIgnore process "mix cmd --cd /src/modules/defaults mix dagger.entrypoint.invoke Defaults" did not complete successfully: exit code: 1 Stderr:...
cc @TomChv @mircubed can we update this example?
This should have been fixed in https://github.com/moby/buildkit/pull/4142 (see https://github.com/moby/buildkit/pull/4069 for more context). Not sure which version of buildkit is vendored in moby 26.1.2 though, so not sure if it includes...
Managed to find where we discussed this before. https://github.com/dagger/dagger/pull/8436#discussion_r1763662136 @TomChv @helderco We always *wanted* to do this, but it just needed to be implemented separately.
I *think* this is already fixed by https://github.com/moby/buildkit/pull/4161 - cc @jsternberg @tonistiigi. Looks like the issue number in the description for that PR isn't right either, should it have been...
Is there a way we can make this change without breaking modules that have already been published to the daggerverse? Can we change the behavior based on the `engineVersion`?
If we're still going to work on it in the future, shouldn't it remain open :thinking: We should only close it if it's no longer applicable, and we're *never* going...
It does look like there are things that are really are wanting it for `LABEL`s and such :eyes: Having not thought about this for some time, I'm finding myself agreeing...
Finally got a spare moment :tada: Conclusion from [a prototype](https://github.com/jedevc/buildkit/commit/989adb0ee04e7c4a17fc81ad2a9a1cc1c289e53d) - this seems quite miserable to do correctly :smile: Newlines, escapes, etc, are all slightly fiddly to deal with, annoyingly...
note - some of the runtimes of tests may not be accurately reported - see https://github.com/dagger/dagger/pull/8120.