Jeremy Udit

Results 34 comments of Jeremy Udit

Seems like a good PR to ship with the upcoming v5 changes. Will circle back once the auth fixes are more solid and try to tie this effort in.

The CI failure looks related to a [previously merged PR](https://github.com/terraform-providers/terraform-provider-github/pull/424). ``` ERRO Running error: varcheck: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/terraform-providers/terraform-provider-github/main.go:5:2: could not import github.com/terraform-providers/terraform-provider-github/github (/home/travis/gopath/src/github.com/terraform-providers/terraform-provider-github/github/config.go:11:2: could not import github.com/google/go-github/v31/github...

@smiller171 are you around to take care of the conflict here? 🤔 seems like we can remove the edit to `vendor/github.com/google/go-github/v31/github/github-accessors.go` and we'll be good to merge.

Ah, didn't realize there was more to be done here. We can circle back on this effort another day.

The change here results in a `422` when creating a private repository: ``` === RUN TestAccGithubRepositories/creates_and_updates_repositories_without_error/with_an_individual_account TestAccGithubRepositories/creates_and_updates_repositories_without_error/with_an_individual_account: testing.go:654: Step 0 error: errors during apply: Error: PATCH https://api.github.com/repos/terraformtesting/tf-acc-test-public-qpkje: 422 Visibility is...

Looks like recent updates to the branch protection plumbing has added conflicts to this PR. I've got this queued to address this week, but welcome anyone else jumping in to...

Ran out of credits to test this. Will pick this back up next release when the GHES test suite is available.

Thanks for reporting this and providing the example config as well as timing measurements. 🙇 > 6.2s per repository We can start with bringing this number down. Not sure how...

Took a quick pass at this using the following generated test file: ```console for i in $(seq 1 100); do cat main.tf resource "github_repository" "repo${i}" { name = "repo${i}" auto_init...

Thanks for confirming. Adding `github_branch_protection` to the test above reveals this poor performance. ``` for i in $(seq 1 100); do cat main.tf resource "github_repository" "repo${i}" { name = "repo${i}"...