Jeremy Udit

Performed a round of measurements that compared `v3.1.0` and `v2.9.2` (GraphQL vs. REST implementations). Some observations below: - For a single repository, performance was similar between versions (numbers below) -...

Given the results above, here are some recommendations: - Refine the GraphQL query to be less costly (current shown below) - Revert the `github_branch_protection` back to the REST implementation, but...

@fabiendelpierre thanks for getting this published for review. This one makes sense for an upcoming feature release. It is now tracked for further testing.

🤔 our underlying [library](https://github.com/google/go-github/blob/v32.0.0/github/misc.go#L142-L165) does not have support for this and the [GraphQL API](https://developer.github.com/v4/explorer/) is also not showing support for the `web` and `api` blocks. My recommendation is we wait...

🤔 maybe we document this as a breaking change? I can get the CHANGELOG updated if it helps boost visibility of the `state replace-provider` procedure above.

```hcl terraform { required_providers { github = { source = "integrations/github" } } } ``` Adding the `required_providers` configuration block may unblock others experiencing this.

Ran into the following when validating this: ``` === RUN TestAccGithubTeamHierarchical/creates_a_hierarchy_of_teams_using_parent_slug/with_an_organization_account testing.go:654: Step 0 error: After applying this step, the plan was not empty: DIFF: UPDATE: github_team.child create_default_maintainer: "false" =>...

Looks like recent updates to the branch protection plumbing has added conflicts to this PR. I've got this queued to address this week, but welcome anyone else jumping in to...

On further reading, we are running into an incompatibility between the `v3` and `graphql` APIs. GitHub has support queued for the [`createBranchProtection`](https://docs.github.com/en/free-pro-team@latest/graphql/reference/mutations#createbranchprotectionrule) mutation, while this is already supported via the...

@k24dizzle added a comment to the underlying issue over in: https://github.com/integrations/terraform-provider-github/issues/305#issuecomment-814084663. I recommend we can proceed with a new PR that adds the features to the GraphQL version of this...