fix assets_url attribute typo

[smiller171]

I noticed that the attribute assets_url was typod to be asserts_url. This PR is my attempt to fix that mistake without breaking anyone's existing Terraform code.

~~I'm not sure I've handled the deprecation message properly, but I'm happy to make any adjustments needed.~~

I definitely didn't do the deprecation message right and have removed it to allow the tests to pass. Any guidance on how to implement the deprecation message would be appreciated.

[jcudit]

The CI failure looks related to a previously merged PR.

ERRO Running error: varcheck: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/terraform-providers/terraform-provider-github/main.go:5:2: could not import github.com/terraform-providers/terraform-provider-github/github (/home/travis/gopath/src/github.com/terraform-providers/terraform-provider-github/github/config.go:11:2: could not import github.com/google/go-github/v31/github (/home/travis/gopath/src/github.com/terraform-providers/terraform-provider-github/vendor/github.com/google/go-github/v31/github/github-accessors.go:11338:2: undeclared name: dataSource))] 

/cc @anGie44 in case this looks familiar ☝️

[smiller171]

@jcudit No, that CI failure was from me copying code without understanding it to try to make a deprecation message work.

[jcudit]

@smiller171 are you around to take care of the conflict here? 🤔 seems like we can remove the edit to vendor/github.com/google/go-github/v31/github/github-accessors.go and we'll be good to merge.

[smiller171]

@jcudit I've rebased and reverted the change to github-accessors. It's been a very long time since I looked at this, and I know I never came back to implement that deprecation message.

Also it looks like a bunch of tests are failing now...

[jcudit]

Ah, didn't realize there was more to be done here. We can circle back on this effort another day.

[nickfloyd]

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

[github-actions[bot]]

👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!