Marco Hutter

Results 1073 comments of Marco Hutter

@alarkbentley One important aspect that was missing in the description: When you open the sandcastle (and it shows the globe), and you _double click_ the label, then (it zooms to...

That ^ is a very valid point. > ... the current status quo is that one has to actually fully parse and inspect into the fields to build an actual...

Not sure whether it's on the radar (I know that there currently is some turmoils around this topic...), but the wording and description around `COLOR_0` may have to be updated....

The missing `freeze`s and the different equality checks also caught my attention here. While `Object.freeze` cannot be applied to a typed array, it might **in theory** be possible to replace...

Just as a short "ack": I quickly looked over the freezing approaches. The `makeFrozenMatrix` one is more accessible and easier to understand, but... `freezeMatrix` raises the bar pretty high in...

Ahh, yeah... the equality. There's always a chance to bring up https://eqeq.js.org/ One reason for why I'm asking is that some Jasmine matchers are re-wired in [`addDefaultMatchers.js`](https://github.com/CesiumGS/cesium/blob/1dcf97348f468bd0998f0a6a6679c24f4af5d2bd/Specs/addDefaultMatchers.js#L191). For completeness, let...

I'll have to leave some of the considerations here to others (_or_ spend more time with dedicated tests and reading). But a small correction to what I said earlier: The...

It may be a bit of a tangent (at first glance), but I see some connection to https://github.com/CesiumGS/cesium/issues/12780 here. Imagine `Cartesian3` was an interface with different implementations. You could create...

> why don't we make a Matrix4 that has-a Float64Array? @Beilinson May chime in with additional details, but I think that some of the performance benefits could be attributed to...

> Based on what you've said, it sounds like you were originally planning to do something like this by making Matrix4 extend Float64Array but, as @javagl said, this exposes this...