Marco Hutter

Results 1078 comments of Marco Hutter

The way how exactly the `undefined` case is handled here **may** still cause problems later. **Disclaimer: I don't know whether this is relevant here!** Figuring that out would require to...

I'm not sure what the "approach" referred to, but to avoid misunderstandings: When I mentioned something like `projectOptional` then this was **not** a proposal/suggestion to _introduce_ such a method. (Adding...

I probably was to slow here 😬 ... let's see what Gabby says...

Adding a new abstract function to an existing interface is a breaking change ... for _implementors_. If someone has implemented some `MyVerySpecialProjection` that implements `MapProjection`, then this will break. I...

Not sure who that question was aimed at, but regardless of that, the clarification may be useful: What you proposed is to not introduce a new function, and not check...

Mentioning that "custom `measureText`" triggered some memories about https://github.com/CesiumGS/cesium/pull/11747 . It should be easy (nearly trivial) to replace it, and IIRC that PR was already pretty complete, but ... there...

This has been ""tracked"" in https://github.com/CesiumGS/cesium/issues/12823 and https://github.com/CesiumGS/cesium/issues/11446 (note: one is closed, the other one open), with several PRs associated with them where this _happened_ or was supposed to be...

The is no support for BSON right now. _Theoretically_, there could be a dedicated [chunk type](https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#chunks-overview) for this. So in addition to `JSON` or `BIN`, there _could_ be `BSON`. But...

The ratio between "incompatiblity" and "benefit" does not looks soooo good for me right now - to some extent, because the latter is "zero": We could *rename* the constants, but...

I agree that readability is an issue. Although one memorizes the most common GL constants sooner or later when manually inspecting glTF files, the fact that I once thought that...