James M Snell
James M Snell
I agree with @joyeecheung here. The conversion to use `ToU8StringView()` can be done separately.
Can you include a description of the use case in the PR text?
> For example https://nodejs.org/en/blog/announcements/making-nodejs-downloads-reliable I'm not sure how this counts as "community content". It was written by a member of the website team discussing the changes that were made to...
> The marketing team has a bus factor of 2. AFAIK they are both based on U.S. west coast and seem to be in proximity to each other quite often....
+1. Thank you!
there were no objections and all approvals, so I *think* it's approved, but we can verify for sure in the next TSC call. From there, you'd need the @nodejs/moderation team...
Btw I should have time to look at this PR this upcoming weekend
If that's the case, it would likely be easiest to rename the existing macros and define the current names as aliases. Then the follow on PR after the updates are...
> IMO the KJ_ASSERT_SOME macros should probably be defined to work only on Maybe from the start -- not on pointers. Ah yeah, that's a good point. We've had confusion...