James M Snell

Results 754 comments of James M Snell

I'm unable to reproduce any failure here with workerd given the example included. The error that you mention ("Parser error: The memory limit has been exceeded") is an error that...

The `DataUrl` implementation is entirely separate from the `HTMLRewriter` and we do not automatically parse data urls that are embedded in a stream. The only place a `data:` URL is...

> When you say you aren't able to reproduce this bug, what do you notice on the response? Are you getting 25 bytes back, or the full 10MB? Keeping in...

It's possible since in that path something may be injecting polyfills and maybe HTMLRewriter use into the worker. Take a look through the compiled source that the CLI generates and...

That's fine, an understandable. At the very least, it might make sense to add some detail to the output so it's at least more helpful than returning `{}`... something like...

The mtu path Discovery bit definitely is, although it may not be supported on *all* platforms. The ECN part is going to be more difficult. I'll work on each separately...

While that is true, native addons *do* make use of `Environment` directly. A quick search on cs.github.com reveals a number of native addons that directly use this API.

https://github.com/search?type=code&q=%22node%3A%3AEnvironment%3A%3AGetCurrent%28%22+language%3AC%2B%2B&l=C%2B%2B