James M Snell

Results 691 comments of James M Snell

The failure in CI here is not a flaky failure. It's relevant to the change being made here. That should be fixed before trying CI again.

While I'm not opposed to the idea, I'm not sure if the project readme is the right place for it and we'd need some guidelines around it. For instance, each...

Another important thing to keep in mind is that Github Sponsors and other sponsorship services may not be available as an option for all Node.js contributors if they happen to...

This is not a bug. We have intentionally not implemented `URL.createObjectIURL()` in workers. @anonrig has a PR that adds placeholders that will explicitly throw but implementing these is not currently...

New custom error types like this tend to be difficult to implement in practice. I'd almost prefer for DOMException to allow for an arbitrary `details` own property that could express...

@bakkot ... Good point on QuotaExceeded already being used in other contexts. Given that I think I can live with it. @domenic ... My preference for LimitExceeded is really just...

@nodejs/tsc ... particularly interested in your thoughts on this. It's not clear at all what the correct value for the `errno` property is.

The issue is that it is inconsistent with the errno values we use elsewhere. ![Image](https://github.com/user-attachments/assets/1c7e88c3-ab7e-4320-8914-a867e54a328d)

For a good example, look at the `test/parallel/test-dns-resolve-promises.js`, which intentionally triggers an `EPERM` whose `errno` is `-1` and not `1`. Also look at `test/parallel/test-fs- error-messages.js` which very specifically tests that...