James M Snell

Results 674 comments of James M Snell

I don't really have a strong opinion on it. The code change looks fine but not sure if it's worthwhile or not. @nodejs/testing folks?

`PromiseWithResolvers` isn't in primordials yet, is it?

@anonrig ... I see you marked this `author ready` but the PR is still a draft. Going to remove the label for now until you confirm this is ready.

> We should probably wait for 20.x to be in maintenance so it does not create conflicts when backporting other PRs (we could also wait for V8 to drop the...

Yeah, it appears to be a segfault (access violation) that appears to only happen on windows as far as I can determine. Will need a windows machine to investigate further....

Not sure yet. I *think* maybe the python runner but can't be certain. I'm running an experiment in #54818 that removes both the node:test runner and the python test runner...

I would be too! But just going through due diligence! It's also possible this isn't a problem with the tests at all and something wrong with the windows host running...

Sadly looks like it needs a rebase after the most recent v8 update

Keep in mind that supporting `AsyncIterable` and `Iterable` as the `body` are non-standard extensions that I really wish undici hadn't implemented unilaterally but they do make sense. Given that they...

`Request` and `Response` are web platform standard APIs. Even in Node.js extending the behavior of web standard APIs in non-standard ways is strongly frowned upon and typically we wouldn't have...