test: execute shell directly for refresh()

[anonrig]

What if we just called the shell directly to avoid the cost of booting a Node.js instance?

cc @nodejs/build any concerns?

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.14%. Comparing base (b181535) to head (5888bc2). Report is 11 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #55051   +/-   ##
=======================================
  Coverage   89.13%   89.14%           
=======================================
  Files         665      665           
  Lines      193165   193179   +14     
  Branches    37191    37196    +5     
=======================================
+ Hits       172181   172204   +23     
- Misses      13729    13730    +1     
+ Partials     7255     7245   -10     

see 38 files with indirect coverage changes

[anonrig]

cc @nodejs/cpp-reviewers @nodejs/tsc would you mind reviewing?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63735/

[anonrig]

@jasnell @mcollina would you mind reviewing this PR? is it a good idea or a bad one, i'm not sure.

[jasnell]

I don't really have a strong opinion on it. The code change looks fine but not sure if it's worthwhile or not. @nodejs/testing folks?

[mcollina]

I expect problems in windows, but if we can get it to pass on CI it's ok.

[anonrig]

I expect problems in windows, but if we can get it to pass on CI it's ok.

This PR doesn't update Windows implementation. Only UNIX

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64716/

[anonrig]

cc @aduh95 @cjihrig can you re-review? I've addressed your comments.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65075/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65102/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65109/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65118/

[nodejs-github-bot]

Landed in 03e9adf876e2039604a038b2eb1476bf4a9e1774