James M Snell

Results 674 comments of James M Snell

> ... Can't we re-use `ReadableStream.from` implementation for this ... Yes, absolutely. Instead of passing the Node.js `stream.Readable` directly there are two choices that are valid per the spec: *...

Not quite sure what you're asking for @IgorMinar ... the runtime *already* supports using either the `ReadableStream.from(...)` or `nodeReadable.toWeb(...)` options. Neither are great because they both carry a fair amount...

> Does the runtime team plan to implement AsyncIterable, Iterable and if yes when. If it is added to the standard, yes. When it is added. I would prefer not...

There will always be limitations to workerd being *really* Node.js compatible which is why we've gone with the hybrid polyfill model... favoring the use of polyfills to fill in gaps...

Should be noted that the v8 patch is temporary. A future v8 update will include it and the patch will be dropped.

Optional Side Quest: we should see about a clang-tidy rule to catch uses of things like `std::vector`, I know this compile time flag is supposed to help check that but...

This is a first attempt at resolving https://github.com/whatwg/webidl/issues/1459 /cc @annevk

I'll wait to cleanup the remaining build errors once it is determined whether this will likely move forward or not.

@ronag: > Would this isolate group possibly enable more efficient ways of transferring/sharing resources between isolates in the future? Not really, and in fact if we end up enabling v8...

> If I read this correctly, we need an API to create a new isolate group, and that pass that as an option to the Worker constructor. By default, it...