Joen A.

Results 733 comments of Joen A.

Looks good 👍 👍 I could use a code sanity check, but otherwise this seems good.

Looks good: Did not have time to check out and compile this one, but looking at the code, the markup for the SVG looks a little sensitive: https://raw.githubusercontent.com/Automattic/social-logos/d2f17bcd12a2b183e2a045f4317c2b6684401288/sources/svg/json-feed.svg There are...

Thank you again for the PR. Unlike my last review, I figured out how to check out your repo. No surprise, typo on my part. Again, incredible work. Screenshots: Correct...

Great discussion here. Good points all around. Regarding the technicality of this — we could do as little as _not strip out the color_ of the SVGs. We'd still be...

> Maybe we 'bake' the brand color into each logo (even if it's just one color), and it'll be up to the user of the icons to make all of...

Though these designs are beautiful as always Dave, I'm slightly concerned about the 3 other versions, as they break our rule: > flat, bidimensional look (no faux 3D whatsoever) I...

We make the guidelines, so we can certainly break them :). But I don't think we should break them this far. The flag, it can be argued, is "folded flat"....

Thank you so much for the PR! Screenshot: This is incredibly good work. It has clearance, the outlines are sharp, and overall it renders really well. Based purely on the...

Nice one, thanks for the ping! Is there a neat new GIF functionality in the mobile version? Gutenberg web of course supports animated GIFs like any other web-app, but there...

Good thoughts. Similar to how mobile extends the Image block to add GIF support, it seems like the GIF keyword would be most appropriate as an extension as well.