social-logos icon indicating copy to clipboard operation
social-logos copied to clipboard

Add JSON Feed Icon

Open rickcurran opened this issue 6 years ago • 2 comments

This adds a JSON Feed Icon. JSON Feed is an alternative to RSS feeds, created by Manton Reece and Brent Simmons, I thought this was worth adding to social icons.

Icon sourced from JSONFeed Github repo: https://github.com/brentsimmons/JSONFeed/tree/master/graphics

rickcurran avatar Aug 07 '19 10:08 rickcurran

Looks good:

Screenshot 2019-08-08 at 09 27 06

Did not have time to check out and compile this one, but looking at the code, the markup for the SVG looks a little sensitive: https://raw.githubusercontent.com/Automattic/social-logos/d2f17bcd12a2b183e2a045f4317c2b6684401288/sources/svg/json-feed.svg

There are some empty groups and some translates thrown in there, which render fine and might be caught by our minimizer. But to be sure it might be good to flatten and simplify the source file manually. If you have access to illustrator:

  1. Open the source svg
  2. Delete invisible groups (usually white arrow key to select handles in the corners then delete key)
  3. Select all, use pathfinder to "make compound shape" then "expand"
  4. Select all, copy, create new file 24x24, ctrl shift V to paste in place, export as SVG.

If you need help with this let me know.

Thanks again!

jasmussen avatar Aug 08 '19 07:08 jasmussen

Hi, no problem, I've removed these groups inside Illustrator, they still persisted even when exporting from Illustrator but I did a manual cleanup in the SVG source instead.

rickcurran avatar Aug 08 '19 09:08 rickcurran