social-logos
social-logos copied to clipboard
Automattic
Added 4 Stackoverflow Family icons
This adds 4 Stackoverflow family icons:
- Stack Exchange
- Stack Overflow
- Super User
- Server Fault
Original Logos from Stack Overflow Logos and Icons: https://stackoverflow.com/company/logos
Thank you again for the PR. Unlike my last review, I figured out how to check out your repo. No surprise, typo on my part.
Again, incredible work. Screenshots:
Correct dimensions, good clearance, great work. Out of the four, only serverfault and stack exchange look blurry at 24x24. This is some times impossible to avoid, and not a blocker per se, but just as a question did you "massage" the scale and y-coordinates to try and achieve the best crispness? If yes and this is the best, then 👍 👍, just making sure.
The larger question and why I would appreciate a sanity check from someone else, perhaps @folletto, is: what is our threshold for adding icons? These are 4 of the stack* sites, two of them I use often. But I know there are many more than these. Do we have any guidelines for which icons go into the set and which don't?
I'll double-check the Server Fault icon just to be sure, it should have been aligned x / y pixel accurately and also the width so I wonder if it's just the individual elements widths being not so pixel-accurate.
In regard to the amount of icons I did look at adding other icons but these 4 are historically the original 'core' SO sites in that they existed before Stack Exchange became a thing, so perhaps that's why only those four logos are included on that SO Company Logos page I linked too. There are a lot of other site which technically are Stack Exchange sites. But yep, it's a fair point that we might want to add those, I suspect though that many of their logos were not designed with flat, small versions in mind so they may not scale well.
Ok, I've gone back and checked the Server Fault icon, I had the overall icon aligned x / y accurately and its width set pixel accurately, however, it turns out that all the separate elements within the icon are actually misaligned in the original file I downloaded from the SO logos page! So that was probably part of the problem. I've aligned them better and adjusted widths / heights of each rect element a little bit as they were extremely close to being pixel accurate, so hopefully this should render a lot better.
I've tweaked the Stack Exchange icon now, this also had some mis-aligned / unequal widths on the elements in the icon's source file. I've aligned them and set the widths more consistently now.
The larger question and why I would appreciate a sanity check from someone else, perhaps @folletto, is: what is our threshold for adding icons? These are 4 of the stack* sites, two of them I use often. But I know there are many more than these. Do we have any guidelines for which icons go into the set and which don't?
We haven't defined a clear threshold I think.
I'm however operating on this rule: Social Logos adds only the "main" social site icon.
This rule however has problems with Stack Overflow specifically, because while technically ALL these sites are Stack Overflow, their strategy is to present each one with their own identity, which means many different icons. Which is not ideal.
Which then will make me switch to a second tier rule: how do we mean to use them?
So: @rickcurran, how are the other 3 icons other than the main Stack Overflow one going to be used?
Thanks @folletto, for my initial logic for submitting these 4 is that I see these 4 icons as distinct entities and I think SO see it that way too as it's the only logos they provide on their Icons and Logos page (https://stackoverflow.com/company/logos).
Primarily I think this is because Stack Overflow, Server Fault and Super User predate "Stack Exchange" as a way of having multiple Q&A sites. Stack Overflow came first, then Server Fault and Super User were established, after those were formed I think the idea of Stack Exchange was established in response to a need for a broad range of subject-specific Q&A sites.
So arguably, despite their heritage, Server Fault and Super User can be considered part of the Stack Exchange family of sites, but perhaps also arguably so should Stack Overflow! Obviously Stack Overflow is the most well known of them all so that makes it the most appropriate one out of them all.
I'd say that Stack Overflow and Stack Exchange are the two key icons out of the four. Taking the logic that there are a lot of different sites under Stack Exchange then I can see the argument for having the Stack Exchange icon being used to represent any SO site apart from Stack Overflow itself.
Ok, just to be clear: there isn't a usage right now? Is the proposal to add them just to make the set more complete?
Yes, it's to make the set more complete. There was an issue filed a while back https://github.com/Automattic/social-logos/issues/54 where someone asked for SO and SE icons. I just added the other two as per my reasoning above.
I'm also looking to add support for more icons in the Social Icons widget in Jetpack, so they need to be added here first.
Ok makes sense. Since there's no specific usage, I'd then err on the "few" sides. Let's go ahead with your proposal to add only Stack Exchange and Stack Overflow for now.
Ok, I'll remove the Super User and Server Fault icons and push up a new commit.