social-logos icon indicating copy to clipboard operation
social-logos copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

Add TripAdvisor logo

Open rickcurran opened this issue 4 years ago • 2 comments

This adds a TripAdvisor logo.

rickcurran avatar Aug 07 '19 10:08 rickcurran

Thank you so much for the PR!

Screenshot:

Screenshot 2019-08-08 at 09 15 52

This is incredibly good work. It has clearance, the outlines are sharp, and overall it renders really well. Based purely on the visuals here, 👍 👍 from a visual POV.

My Git-fu is failing me though, so I wasn't able to check out your repository and compile it. This is almost certainly my own fault, but I would appreciate a code sanity check from someone else, and if that looks good, ship it!

jasmussen avatar Aug 08 '19 07:08 jasmussen

Thanks, I just set the x / y positioning pixel accurate in the icon-template and tried to get it's width to set pixel accurately too. I just followed the guidelines of the template and also compared with some of the existing icons to see how they looked in regard to spacing / margins.

rickcurran avatar Aug 08 '19 08:08 rickcurran