Joen A.
Joen A.
I clarified the mockup and added "Needs dev".
Very long titles would be less elided, and future screens that use the same layout but show more fields might show more. It feels like a small ergonomic change that...
I'd love for a separate "Caption" element to be stylable, just like buttons, forms, inputs, etc. Right now that's missing, and I'd like to see that, this would also allow...
Marking this one ready for review. The combination of background blur, a refined gradient, and the text shadow keeps contrast the same as before in most contexts, but improves it...
Just wanted to note that I really appreciate your excellent feedback, and will address it! Other things got in the way first, but the review hasn't been forgotten. Thank you...
Took a stab. This was harder to address than I thought it would've been, so it needed kind of a fresh approach. What I've done now, and I believe this...
Great feedback as always, thank you. > Personally, I feel that blur(4px) has a slightly large impact depending on the content of the image. What do you think about 2px?...
> Another thing I noticed is that the caption height is not constrained. Should we apply max-height: 40% if we want it to match the scrim? I intentionally let it...
Just checking, is this good to merge?
I'm going to merge, but happy to follow up!