Jared Norman
Jared Norman
You really didn't need to write (and make me read) a small essay to point out that the implementation is incomplete. Please proceed with suggesting a solution. We want canonicals...
This is currently the intended behaviour, so this isn't strictly a "bug", but I'm open to changing the behaviour here.
@senemsoy Do you want to tackle this?
That's not been decided. Sometimes community members do it, sometimes maintainers. It's something we need to figure out pretty quick, though. Ideally we'd have sorted it by now.
Paperclip is still supported.
What's the status of this PR? It's a very large draft that I don't want to just leave sitting here.
I looked through my notifications starting from the most recent. I was wondering where all these excellent little changes from @mamhoff came from... and now I know.
My guess is that this component is playing nice with the CDN setup: https://github.com/solidusio/solidus/blob/f2a32d60ce80c402fc93932d15ed1c47d4ac0383/admin/app/components/solidus_admin/ui/icon/component.rb#L26
Ah yes, I think this is resolved now!
PR needs fixing, but we want this.