solidus_subscriptions icon indicating copy to clipboard operation
solidus_subscriptions copied to clipboard

allow use without solidus_backend

Open ccarruitero opened this issue 1 year ago • 4 comments

Summary

Currently solidus_subscriptions has references to solidus_backend, even when solidus_backend isn't a dependency on gemspec.

It will be easier just add solidus_backend as dependency in gemspec, but I think the plan with solidus_admin is to eventually replace solidus_backend. So, this PR allows use solidus_subscriptions extension without solidus_backend.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

ccarruitero avatar May 04 '24 16:05 ccarruitero

@jarednorman whats the general opinion on this?

fthobe avatar Jan 10 '25 12:01 fthobe

PR needs fixing, but we want this.

jarednorman avatar Jan 13 '25 18:01 jarednorman

@jarednorman ok, we have added it to the list and will tackle this in a bugfix run we surely need in march / april.

fthobe avatar Jan 13 '25 18:01 fthobe

@jarednorman do you have information to add here?

fthobe avatar Jan 17 '25 13:01 fthobe