solidus icon indicating copy to clipboard operation
solidus copied to clipboard

Admin stores add edit

Open chaimann opened this issue 10 months ago • 4 comments

Summary

Implement interface to create/edit stores.

image image

Other changes

  • Rename :resource_modal turbo frame to :resource_form and add an overridable method #resource_form_frame in resources_controller, that returns default frame name :resource_form.
  • ~UI select component: add support for :include_blank option. Component now will only accept array for choices. Updated usage in a few places where a string has been passed instead of an array (user store credits)~ - split to #6279.
  • ~Updated layout to accommodate alerts display. Added FlashHelper to differentiate between toast flashes and alert flashes~ - split to #6280.
  • ~Updated usages of flash[:success] to flash[:notice] to be consistent~ - split to #6280.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

chaimann avatar May 05 '25 15:05 chaimann

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.64%. Comparing base (2aed8c3) to head (40e76d7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6228      +/-   ##
==========================================
- Coverage   88.86%   86.64%   -2.22%     
==========================================
  Files         857      520     -337     
  Lines       18415    11947    -6468     
==========================================
- Hits        16365    10352    -6013     
+ Misses       2050     1595     -455     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 14 '25 18:05 codecov[bot]

going to split few changes into separate PRs

chaimann avatar Jun 05 '25 10:06 chaimann

What's the status of this PR? It's a very large draft that I don't want to just leave sitting here.

jarednorman avatar Jul 24 '25 18:07 jarednorman

@jarednorman it was waiting for flashes PR to be merged, so now I can move it forward

chaimann avatar Jul 28 '25 08:07 chaimann