Jan Segre comments

Results 100 comments of


                                            Jan Segre

Improve tracked metrics

This would probably require a migration path to change the names, but it seems like an improvement.

Openapi for address_search needs an update

This still applies, and in general we could have better testing of the OpenAPI descriptions to check if they match the actual implementation.

Include a syntax analysis for TX scripts before running the script.

This makes sense, I think the only "syntax analysis" we currently do is pattern matching for "standard scripts", but if we parse the scripts before running them we could catch...

Limit the number of websocket connections

This makes sense and is probably not something that can be easily made in nginx.

Performance impact of using RocksDB indexes

This is still relevant for some cases.

QA issue during release-candidate v0.58.0-rc1

Reviewers : @msbrogli @luislhl

Initialization of `hathor.indexes.RocksDBMempoolTipsIndex` is too slow

This issue still applies. The initialization itself has been dealt with by #1100 but this is not enough since the same performance issue is observed during a sync from scratch.

Parse and validate API parameters from OpenAPI

This still makes sense. At the very least we could have automated tests the OpenAPI definitions against the API implementation.

`top` is not calculating the time spent answering HTTP requests

The `top` subsystem doesn't measure everything. This could be a relevant improvement.

Prevent propagation of voided vertices in `on_new_tx()`

Is this specific to sync-v2? Either way we'd need a careful examination before doing this.